New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parity handling of `null` in various operators #2129

Open

ike709 wants to merge 2 commits into OpenDreamProject:master from ike709:easyfixes

Collaborator

ike709 commented Dec 10, 2024

See the moved unit tests.

Summary:

Bit shifting a LHS float and RHS null returns LHS as an integer
Bit masking any float and null returns 0
Bit XORing two nulls returns null
Bit XORing a LHS float and RHS null returns LHS as an integer
Bit XORing a LHS null and RHS float returns RHS as an integer

ike709 added 2 commits

December 9, 2024 19:57


          Improve parity handling of null in various operators

fff6c2a


          remove duplicated code

85b4640

boring-cyborg bot added the Runtime label

github-actions bot added the size/M label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels